Fixed Bug: Wrong title in Result Search page
—
!!1!
!
Please click in the box above and give a meaningful
title, then fill out any information below that you can.
It is all optional,
and I’m grateful for whatever you provide.
!
!2!
!
—
!!3!
!
>
—
!!4!
!
Your name:
Giulio Piancastelli
—
!!5!
!
!
!6!
!
Soks version:
1.0.0
—
!!7!
!
!
!8!
!
Your operating system:
Mac OS X 10.4.2
—
!!9!
!
!
!10!
!
Your version of
ruby: 1.8.2
—
!!11!
!
!
!12!
!
Your browser:
Firefox 1.0.6,
Safari 2.0
—
!!13!
!
—
!!14!
!
—
!!15!
!
And please describe the problem below:
!
!16!
!
—
!!17!
!
The Result Search page appears to have the
title of the last page found in the displayed list.
For example:
I’ve searched for
“template”
; the Result Search display a list of page titles,
starting with
title matching,
then text matching;
here,
the last page listed is
“
Recent changes to this site”.
The HTML
title of the Result Search is exactly the same,
while it should be
“Result of Search for
‘template’
” or something similar.
!
!18!
!
—
!!19!
!
And if you have any suggestions for the cause or a fix,
please put it below:
!
!20!
!
—
!!21!
!
Haven’t looked at the code
(yet?
) sorry.
But I believe this should be an easy one to spot and fix!
;
)
—
!!22!
!
—
!!23!
!
Thank you
very much
—
!!24!
!
!
!25!
!
—
!!26!
!
Yep,
this is an easy one.
Thank you Giulio.
Patch is to the soks/templates/default/views/frame.rhtml file:
!
!27!
!
!
!28!
!
!
!29!
!
!
!30!
!
!
!31!
!
—
!!32!
!
—
tamc !
!33!
!
!
!34!
!
—
!!35!
!
I’d better have quotes surrounding the query in the page
title, but it’s just as good as you’ve fixed it.
Thanks.
!
!36!
!
!
!37!
!
—
!!38!
!
Quotes it is then.
Done in the CVS version.
—
tamc !
!39!
!
—
!!40!
!
Giulio Piancastelli
—
!!41!
!
—
!!42!
!
Fixed in v1-0-1
—
!!43!
!
