Please click in the box above and give a meaningful title, then fill out any information below that you can. It is all optional, and I’m grateful for whatever you provide.
- Your name: Giulio Piancastelli
- Soks version: 1.0.0
- Your operating system: Mac OS X 10.4.2
- Your version of ruby: 1.8.2
- Your browser: Firefox 1.0.6, Safari 2.0
And please describe the problem below:
The Result Search page appears to have the title of the last page found in the displayed list. For example: I’ve searched for “template”; the Result Search display a list of page titles, starting with title matching, then text matching; here, the last page listed is “Recent changes to this site”. The HTML title of the Result Search is exactly the same, while it should be “Result of Search for ‘template’” or something similar.
And if you have any suggestions for the cause or a fix, please put it below:
Haven’t looked at the code (yet?) sorry. But I believe this should be an easy one to spot and fix! ;)
Thank you very much
Yep, this is an easy one. Thank you Giulio. Patch is to the soks/templates/default/views/frame.rhtml file:
< <title><%= page.name %></title>
---
> <title><%= query['regex'] ? "Results of search for '#{query['regex']}'" : page.name %></title>
—tamc
I’d better have quotes surrounding the query in the page title, but it’s just as good as you’ve fixed it. Thanks.
Quotes it is then. Done in the CVS version. —tamc
Thanks again! —Giulio Piancastelli
Fixed in v1-0-1
